decode batch message #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfstudy
requested changes
May 13, 2019
core/msg/message.go
Outdated
|
|
||
| func DecodeBatchMessage(msg *Message)([]*SingleMessage, error){ | ||
| num := msg.Meta.GetNumMessagesInBatch() | ||
| if num==0{ |
There was a problem hiding this comment.
Suggested change
| if num==0{ | |
| if num == 0 { |
core/msg/message.go
Outdated
| func DecodeBatchMessage(msg *Message)([]*SingleMessage, error){ | ||
| num := msg.Meta.GetNumMessagesInBatch() | ||
| if num==0{ | ||
| return nil,errors.New("num_message_in_batch is nil or 0") |
There was a problem hiding this comment.
Suggested change
| return nil,errors.New("num_message_in_batch is nil or 0") | |
| return nil, errors.New("num_message_in_batch is nil or 0") |
core/msg/message.go
Outdated
| if num==0{ | ||
| return nil,errors.New("num_message_in_batch is nil or 0") | ||
| } | ||
| return DecodeBatchPayload(msg.Payload,num) |
There was a problem hiding this comment.
Suggested change
| return DecodeBatchPayload(msg.Payload,num) | |
| return DecodeBatchPayload(msg.Payload, num) |
core/msg/message_test.go
Outdated
| ) | ||
|
|
||
| func TestDecodeBatchPayload(t *testing.T){ | ||
| payload := []byte{0,0,0,2,24,12,104,101,108,108,111,45,112,117,108,115,97,114} // hello-pulsar |
There was a problem hiding this comment.
Suggested change
| payload := []byte{0,0,0,2,24,12,104,101,108,108,111,45,112,117,108,115,97,114} // hello-pulsar | |
| payload := []byte{0, 0, 0, 2, 24, 12, 104, 101, 108, 108, 111, 45, 112, 117, 108, 115, 97, 114} // hello-pulsar |
core/msg/message_test.go
Outdated
| func TestDecodeBatchPayload(t *testing.T){ | ||
| payload := []byte{0,0,0,2,24,12,104,101,108,108,111,45,112,117,108,115,97,114} // hello-pulsar | ||
| list,err := DecodeBatchPayload(payload,1) | ||
| if err!=nil{ |
There was a problem hiding this comment.
Suggested change
| if err!=nil{ | |
| if err != nil { |
core/msg/message_test.go
Outdated
| if err!=nil{ | ||
| t.Fatal(err) | ||
| } | ||
| if get,want := len(list),1;get!=want{ |
There was a problem hiding this comment.
Suggested change
| if get,want := len(list),1;get!=want{ | |
| if get, want := len(list), 1; get!=want { |
core/msg/message_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| if get,want := len(list),1;get!=want{ | ||
| t.Errorf("want %v, but get %v",get,want) |
There was a problem hiding this comment.
Suggested change
| t.Errorf("want %v, but get %v",get,want) | |
| t.Errorf("want %v, but get %v", get, want) |
core/msg/message_test.go
Outdated
| } | ||
|
|
||
| m := list[0] | ||
| if get,want := string(m.SinglePayload), "hello-pulsar";get!=want{ |
There was a problem hiding this comment.
Suggested change
| if get,want := string(m.SinglePayload), "hello-pulsar";get!=want{ | |
| if get, want := string(m.SinglePayload), "hello-pulsar"; get != want { |
core/msg/message_test.go
Outdated
|
|
||
| m := list[0] | ||
| if get,want := string(m.SinglePayload), "hello-pulsar";get!=want{ | ||
| t.Errorf("want %v, but get %v",get,want) |
There was a problem hiding this comment.
Suggested change
| t.Errorf("want %v, but get %v",get,want) | |
| t.Errorf("want %v, but get %v",get, want) |
cch123
reviewed
May 13, 2019
cch123
reviewed
May 13, 2019
core/msg/message.go
Outdated
| SinglePayload []byte | ||
| } | ||
|
|
||
| func DecodeBatchMessage(msg *Message)([]*SingleMessage, error){ |
There was a problem hiding this comment.
exported function should have comment
Sorry for so many problems of format, i have fix them. And thank you very much for pointing out every mistake. |
wolfstudy
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a method for parsing the payload generated by the producer using the batch produce option.